Fix notification request specs #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhao-Andy
commented
Jan 2, 2019
| @@ -21,5 +21,5 @@ | |||
| </span> | |||
| </div> | |||
| <% else %> | |||
| <%= render "aggregated_reactions", notification: notification %> | |||
| <%= render "aggregated_reactions", notification: notification, siblings: siblings %> | |||
There was a problem hiding this comment.
Passing along siblings from this file to aggregated_reactions instead of defining it twice (once in this file, another in aggregated_reactions).
| expect(response.body).to include message | ||
| end | ||
|
|
||
| xit "renders the proper message for a single private reaction" do |
There was a problem hiding this comment.
We no longer have "private user" reactions.
| xit "renders the comment's processed HTML" do | ||
| expect(response.body).to include CGI.escapeHTML(comment.processed_html) | ||
| it "renders the comment's processed HTML" do | ||
| expect(response.body).to include comment.processed_html |
There was a problem hiding this comment.
Shouldn't need to escape HTML that is already safe.
Zhao-Andy
changed the title
Zhao-Andy
changed the title
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixes all the notification request specs that were
xited. This should help us feel more comfortable making changes to notifications.Also made a small (performance?) improvement by using an already defined variable.
Added to documentation?