Simplify ArticlesController#feed #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's unneeded complexity in the logic of the feed method, this way what separates each path should be clearer
maestromac
reviewed
Mar 1, 2019
Co-Authored-By: rhymes <rhymesete@gmail.com>
|
Thanks @maestromac! |
|
Nice refactoring ) |
benhalpern
approved these changes
Mar 1, 2019
pr-triage
bot
added
PR: reviewed-approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's unneeded complexity in the logic of the feed method, this way what separates each path should be clearer.
What type of PR is this? (check all applicable)
Description
I came across ArticlesController#feed and noticed that the ORM logic was a bit convoluted and repeated in each if/else clause. Since AR is a lazy and composable ORM, I decided to simplify the logic.
Added to documentation?