Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.scss: Fix color contrast in text colors #2372

Merged
merged 1 commit into from
Apr 11, 2019
Merged

settings.scss: Fix color contrast in text colors #2372

merged 1 commit into from
Apr 11, 2019

Conversation

chinchang
Copy link
Contributor

@chinchang chinchang commented Apr 11, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This PR fixes the text colour of the alert messages which was failing the accessible colour contrast requirement of 4.5:1 ratio.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before:
Screenshot 2019-04-11 16 28 47

After:
Screenshot 2019-04-11 16 29 03

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

CC @benhalpern

The text colour of the alert messages was failing the accessible colour contrast requirement of 4.5:1.
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benhalpern benhalpern merged commit 8f03f87 into forem:master Apr 11, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants