Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented ActiveJob for RateLimitChecker Job #2878

Merged
merged 3 commits into from May 21, 2019
Merged

Implemented ActiveJob for RateLimitChecker Job #2878

merged 3 commits into from May 21, 2019

Conversation

tannakartikey
Copy link
Contributor

@tannakartikey tannakartikey commented May 18, 2019 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • Performing Labor::RateLimitChecker job using ActiveJob
  • Created PingAdmins service

Related Tickets & Documents

#2497

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label May 18, 2019
@CLAassistant
Copy link

CLAassistant commented May 18, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

rhymes
rhymes reviewed May 18, 2019
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tannakartikey, great PR!

Just a few quick notes and it's good to go!

app/jobs/labor/rate_limit_checker_job.rb Outdated Show resolved Hide resolved
app/labor/rate_limit_checker.rb Outdated Show resolved Hide resolved
app/services/labor/ping_admins_service.rb Outdated Show resolved Hide resolved
@tannakartikey
Copy link
Contributor Author

@rhymes I have implemented your suggestions.

@rhymes rhymes requested a review from lightalloy May 18, 2019 15:35
@weekly-digest weekly-digest bot mentioned this pull request May 20, 2019
Closed
lightalloy
lightalloy requested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@lightalloy lightalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr! I added a couple of comments about the code organization.

app/jobs/labor/rate_limit_checker_job.rb Outdated Show resolved Hide resolved
app/services/labor/ping_admins.rb Outdated Show resolved Hide resolved
app/services/labor/ping_admins.rb Outdated Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes PR: unreviewed bot applied label for PR's with no review and removed PR: unreviewed bot applied label for PR's with no review PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels May 20, 2019
@tannakartikey
Copy link
Contributor Author

@lightalloy I made the changes you suggested. Also, started a review. Can you take a look?

@tannakartikey
Copy link
Contributor Author

@lightalloy @rhymes I have removed the spec for PingAdmins class. If it all looks good, do you want me to squash the commits?

@rhymes
Copy link
Contributor

rhymes commented May 20, 2019

@tannakartikey thanks! don't worry about squashing, the commits are squashed on merge

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels May 21, 2019
@benhalpern benhalpern merged commit 03a122f into forem:master May 21, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels May 21, 2019
@tannakartikey tannakartikey mentioned this pull request May 21, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightalloy lightalloy lightalloy approved these changes

@rhymes rhymes rhymes left review comments

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tannakartikey @CLAassistant @rhymes @lightalloy @benhalpern