Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection: remove optional user and add tests #3383

Merged
merged 1 commit into from Aug 2, 2019
Merged

Collection: remove optional user and add tests #3383

merged 1 commit into from Aug 2, 2019

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jul 4, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jul 4, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jul 8, 2019
Closed
@maestromac maestromac added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Aug 1, 2019
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Aug 2, 2019
maestromac
maestromac approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Aug 2, 2019
@maestromac maestromac merged commit 4689cdd into forem:master Aug 2, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Aug 2, 2019
@rhymes rhymes deleted the rhymes/collection-specs branch August 2, 2019 16:23
@weekly-digest weekly-digest bot mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightalloy lightalloy lightalloy left review comments

@benhalpern benhalpern benhalpern left review comments

@maestromac maestromac maestromac approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhymes @lightalloy @benhalpern @maestromac