Refactor Podcasts Bust Cache job #5421
Conversation
pr-triage
bot
added
PR: reviewed-approved
spec/models/podcast_spec.rb
Outdated
| it "triggers cache busting on save" do | ||
| expect { build(:podcast).save }.to have_enqueued_job.on_queue("podcasts_bust_cache").once | ||
| podcast.save | ||
| expect(Podcasts::BustCacheWorker).to have_received(:perform_async).with(podcast.path) |
There was a problem hiding this comment.
just a note: this should probably check the job is in the queue with the sidekiq test helpers, instead of using mocks
There was a problem hiding this comment.
Got it, I will change it ;)
There was a problem hiding this comment.
Lets do this spec like you did the one above and I think this will be ready to go!!!
pr-triage
bot
added
PR: unreviewed
|
@mstruve is this one safe to remove the old job and spec in the same PR? Looks like this is called in an Otherwise, LGTM 💯 |
|
I believe this one is good bc
Is that logic sound? Did I miss any use cases? |
There was a problem hiding this comment.
It makes sense to me! Thanks, @mstruve and @maykonmenezes! 💯
pr-triage
bot
added
PR: reviewed-approved
| before do | ||
| allow(Pages::BustCacheWorker).to receive(:perform_async) | ||
| end | ||
| let(:page) { create(:page) } |
There was a problem hiding this comment.
shouldn't this be a build(:page) ? the reason why this test passes is because create also runs save
There was a problem hiding this comment.
I don't think it matters bc that block below asserts that a new job is enqueued on save. Whether it's a new record or already existing one is inconsequential
What type of PR is this? (check all applicable)
Description
Migrated Podcasts::BustCacheJob to a side worker
Related Tickets & Documents
#5305
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?