[WIP] Upgraded to Preact 10.3.4 #5639
Conversation
| @@ -1,4 +1,3 @@ | |||
| import 'preact/devtools'; | |||
There was a problem hiding this comment.
I've removed preact/devtools as it no longer exists. preact/debug is what should be used, but it should only be for development purposes. I will address this in another PR.
There was a problem hiding this comment.
Thanks for catching this!
| @@ -1,9 +1,9 @@ | |||
| import { h, render } from 'preact'; | |||
| import { Search } from '../src/components/Search'; | |||
| import 'focus-visible' | |||
| import 'focus-visible'; | |||
There was a problem hiding this comment.
A little prettier action happening in a few files.
|
|
||
| document.addEventListener('DOMContentLoaded', () => { | ||
| const root = document.getElementById('nav-search-form-root'); | ||
|
|
||
| render(<Search />, root, root.firstElementChild); | ||
| render(<Search />, root); |
There was a problem hiding this comment.
This is part of the upgrade. VDOM diffing works the way it does in most other libraries, e.g. React.
|
The other issue is related to jest issues as test scores have gone from A -> F 😬 |
|
I need to sort out the tests in the frontend as a lot of the snapshots changed, but the structure is different and information appears to be missing. Maybe Preact X is not compatible with some of the tools we were using for snapshot testing with Preact. Either way, gotta get it sorted. 😉
|
pr-triage
bot
removed
the
PR: unreviewed
|
Tiny update. It looks like there are issues with |
nickytonline
force-pushed
the
nickytonline/upgrade-to-preact-x
branch
from
2a6deaf
to
516f504
Compare
|
I spoke briefly with Jason Miller from Preact, and he is going to look into getting preact-render-spy etc. fixed up. So for the time being, I will put this PR on hold. |
This reverts commit 516f504.
nickytonline
changed the title
nickytonline
force-pushed
the
nickytonline/upgrade-to-preact-x
branch
from
822921e
to
a28fe97
Compare
|
@nickytonline Seems like https://github.com/mzgoddard/preact-render-spy might be abandoned: there's a Preact X fork up at https://github.com/shelacek/preact-render-spy. What do we use |
@joshpuetz, I tried the fork of preact-render-spy and it does not work. We use preact-render-spy for snapshot testing. It does appear to be abandoned although Jason Miller talked about fixing it up. See this Tweet thread between Jason and I. Also, I'm looking to move away from snapshot testing in favour of preact-testing-library. Even enzyme is not considered to be the way to test React components now (so Preact as well). As I mentioned on Slack, react-testing-library is the recommended tool by the React team, so I would be inclined to move towards preact-testing-library. The way I see it panning out is migrating to another testing tool and once all tests are migrated, we can upgrade. |
|
Closing this @Ridhwana as we'll need to make a new PR which will include the new testing tools. |
What type of PR is this? (check all applicable)
Description
Preact has been upgraded to the latest version, Preact X. This gives us hooks, componentDidCatch, fragments etc. See the official release for the whole rundown. Here is the official migration guide for Preact 8.x to X if you're curious why some changes have been made.
I've done a smoke test of the site on my local. Onboarding worked fine, search is good and the site seems to behaving normally.
Storybook appears to be broken still. This is related to work that needs to be done in #3490 and #2034. I will address that in a separate PR.
Related Tickets & Documents
#4243
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?