Change ModerationNotificationJob to ModerationNotificationWorker and move to sidekiq #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruve
suggested changes
Jan 23, 2020
| @@ -82,7 +82,7 @@ def send_moderation_notification(notifiable) | |||
| # TODO: make this work for articles in the future. only works for comments right now | |||
| return if UserBlock.blocking?(notifiable.commentable.user_id, notifiable.user_id) | |||
|
|
|||
| Notifications::ModerationNotificationJob.perform_later(notifiable.id) | |||
| Notifications::ModerationNotificationWorker.perform_async(notifiable.id) | |||
There was a problem hiding this comment.
This method is called from comment in an after_create callback which means nothing has been committed to the database yet. We need to change that comment callback to be after_create_commit
There was a problem hiding this comment.
Sure @mstruve. I'll send the changes. Thanks for reviewing.
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
rhymes
suggested changes
Jan 24, 2020
pr-triage
bot
added
PR: reviewed-changes-requested
Sure @rhymes. I'll fix it |
pr-triage
bot
added
PR: unreviewed
pr-triage
bot
added
PR: reviewed-approved
mstruve
approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
#5305
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?