Move reports views to separate pages #5686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sending message ID to frontend - Deleting Message - Use pusher to delete message realtime
- User can delete or edit their own messages
Message id was not sent to receiver by pusher
…dit_messages Feature/ability to delete and edit messages
…open messages and increasing message number count
…essage is notified to user or not
…ature/ability_to_mention_anyone_in_chat
benhalpern
changed the title
rhymes
reviewed
Jan 24, 2020
| ransack(params[:q]) | ||
| @feedback_messages = @q.result.page(params[:page] || 1).per(5) | ||
| @view = params[:view] | ||
| if @view == "new-articles" |
There was a problem hiding this comment.
if we split these view == in different routes we gain an easier code organization, so instead of /internals/reports?view=name it could be /internal/reports/name and each of the view has its own action method
Comment on lines
+20
to
+26
| <% if @view == "new-articles" %> | ||
| <%= render "new_articles" %> | ||
| <% elsif @view == "suspicious-users" %> | ||
| <%= render "suspicious_users" %> | ||
| <% else %> | ||
| <%= render "reports" if @view.blank? %> | ||
| <% end %> |
There was a problem hiding this comment.
these could just be rendered by the controller.
/internal/reports/new-articles
/internal/reports/suspicious-users
/internal/reports/feedback-messages or just /internal/reports
|
Since this hasn't been active for a while and there are some conflicts I am going to close it. If we still want this feature lets resolve the conflicts, get the specs to run green, then reopen the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This moves the sections of
internal/reportsinto their own pages. I think the performance gains we get will make it smoother for admins to sort, discover, and generally make them check this part of the site more often due to speed of fewer (sometimes slow) queries.