Migrate delayed job that updates media url for podcast episodes #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sidekiq version of delayed job and updating services that used the delayed job * Intentionally removed the defensive check in the sidekiq version. If the episode is missing and there's worker scheduled to update it's media url then that reveals a bug elsewhere and should fail fast instead of skipping ahead. * Also excluded the ambiguous block rule for rspecs since that conflicts with the rspec `expect` block, found that recommentation thanks to rubocop/rubocop#4222 (and rubocop was complaining about this in the pre-commit hook for these changes)
rhymes
approved these changes
Jan 26, 2020
There was a problem hiding this comment.
Good calls! I'm going to ping @lightalloy to review the choice on the podcast worker but it makes sense to me :)
pr-triage
bot
added
PR: reviewed-approved
mstruve
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
LGTM 🚀
Going to push this through since @lightalloy is on vacation for the next week.
pr-triage
bot
added
PR: merged
VegaFromLyra
deleted the
vegafromlyra/migrate-podcast-episodes-media-url-updater-5305
branch
VegaFromLyra
added a commit
to VegaFromLyra/dev.to
that referenced
this pull request
Jan 27, 2020
9 tasks
maestromac
pushed a commit
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
delayed job
the episode is missing and there's worker scheduled to update it's media
url then that reveals a bug elsewhere and should fail fast instead of
skipping ahead.
conflicts with the rspec
expectblock, found that recommentationthanks to Lint/AmbiguousBlockAssociation with Rspec syntax rubocop/rubocop#4222 (and rubocop
was complaining about this in the pre-commit hook for these changes)
Related Tickets & Documents
#5305
Added to documentation?