Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused notifiable action job #5730

Merged
merged 1 commit into from
Jan 27, 2020
Merged

remove unused notifiable action job #5730

merged 1 commit into from
Jan 27, 2020

Conversation

serenaf
Copy link
Contributor

@serenaf serenaf commented Jan 26, 2020 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Follow up from #5588
In this PR we are removing the unused Notifiable Action job

Related Tickets & Documents

#5588
#5305

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Jan 26, 2020
@serenaf serenaf marked this pull request as ready for review January 26, 2020 17:54
@serenaf serenaf requested a review from a team January 26, 2020 17:54
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Jan 26, 2020
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 26, 2020
mstruve
mstruve approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mstruve mstruve merged commit f2d96ba into forem:master Jan 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@mstruve mstruve mstruve approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serenaf @rhymes @mstruve