Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BustHomepageCacheJob and spec #5777

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Remove BustHomepageCacheJob and spec #5777

merged 1 commit into from
Feb 1, 2020

Conversation

atsmith813
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor

Description

Now that #5581 is merged, this is removing the old job.

Related Tickets & Documents

Added to documentation?

  • no documentation needed

get_out_gif

@atsmith813 atsmith813 requested a review from a team January 27, 2020 23:27
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
citizen428
citizen428 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atsmith813 🎉

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 28, 2020
mstruve
mstruve approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@atsmith813 atsmith813 merged commit 928fdd5 into forem:master Feb 1, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 1, 2020
@atsmith813 atsmith813 deleted the atsmith813/remove-bust-homepage-cache-job-5305 branch February 1, 2020 23:54
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@rhymes rhymes rhymes approved these changes

@mstruve mstruve mstruve approved these changes

@vaidehijoshi vaidehijoshi vaidehijoshi approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atsmith813 @citizen428 @rhymes @mstruve @vaidehijoshi