Flaky Spec Try 2: Article Decorator properly handles Names #6048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsmith813
previously approved these changes
Feb 12, 2020
| @@ -57,7 +57,12 @@ def create_article(*args) | |||
| it "creates proper description when it is not present and body is not present and long, and tags are present" do | |||
| body_markdown = "---\ntitle: Title\npublished: false\ndescription:\ntags: heytag\n---\n\n" | |||
| created_article = create_article(body_markdown: body_markdown) | |||
| expect(created_article.description_and_tags).to eq("A post by #{created_article.user.name.delete('.')}. Tagged with heytag.") | |||
| parsed_post_by_string = if created_article.user.name.end_with?(".") | |||
There was a problem hiding this comment.
This is probably a nitpick/style preference so I'm approving this and leaving this as a suggestion.
What about:
parsed_post_by_string = "A post by #{created_article.user.name}"
parsed_post_by_string += "." unless created_article.user.name.end_with?(".")So it kind of reads like, "append a period unless it already ends with a period". Only because I had to look twice. At first, I thought the conditions were the same by accident and then I noticed the period.
There was a problem hiding this comment.
that actually matches really nicely with the way it is written in the decorator +1
Zhao-Andy
previously approved these changes
Feb 12, 2020
There was a problem hiding this comment.
LGTM! Also agree with @atsmith813's suggestion b/c I did a double take too, but overall am pretty indifferent.
atsmith813
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
In a previous PR(#6029) I attempted to fix this flaky spec by removing any periods that might be in the user name figuring if the name is "Sam Jr." then the final period would be removed and we would be good. HOWEVER that doesnt work for a name "Mr. Sam Jr." bc then all of the periods are removed. This updates the spec to use the same
end_withlogic that the method in the decorator uses so it should be super solid now.Related Tickets & Documents
#4884
Added tests?
Added to documentation?