Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add parler.io liquid tag for audio embed #828

Conversation

Projects
None yet
2 participants
@kylegalbraith
Copy link
Contributor

commented Oct 5, 2018

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This is a PR to add a new liquid tag that takes a parler.io audio file and embed it into a post. Right now the parler endpoint has no notion of a user so I can't just use a generic id as the other liquid tags do.

Also, note that this was based on a quick conversation with Ben over Twitter. So we could certainly do more here in the future. I also didn't do a ton of refactoring while I was here as it took a lot longer than I expected to get up and going on a Linux subsystem.

Related Tickets & Documents

There isn't one at this time, but happy to create one if necessary.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

battle scars

@benhalpern

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2018

Hmm, I'm getting some of this in trying to test it out

{% parler https://www.parler.io/audio/73240183203/d53cff009eac2ab1bc9dd8821a638823c39cbcea.7dd28611-b7fc-4cf8-9977-b6e3aaf644a1.mp3 %}

@kylegalbraith

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2018

I had to add some parsing since the url was being interpreted as a <ahref>.

devto-parler-liquid

@benhalpern
Copy link
Collaborator

left a comment

Good to go 😇

@benhalpern benhalpern merged commit f9c19f6 into thepracticaldev:master Oct 16, 2018

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 86% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.