Feature/add parler.io liquid tag for audio embed #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm getting some of this in trying to test it out
|
|
I had to add some parsing since the url was being interpreted as a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This is a PR to add a new liquid tag that takes a parler.io audio file and embed it into a post. Right now the parler endpoint has no notion of a user so I can't just use a generic id as the other liquid tags do.
Also, note that this was based on a quick conversation with Ben over Twitter. So we could certainly do more here in the future. I also didn't do a ton of refactoring while I was here as it took a lot longer than I expected to get up and going on a Linux subsystem.
Related Tickets & Documents
There isn't one at this time, but happy to create one if necessary.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?