Cleanup existing liquid tags #9085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
pr-triage
bot
added
PR: unreviewed
atsmith813
requested review from
rhymes,
citizen428,
juliannatetreault,
vaidehijoshi and
mstruve
vaidehijoshi
approved these changes
Jul 2, 2020
pr-triage
bot
added
PR: partially-approved
| @@ -2,7 +2,7 @@ class KatexTag < Liquid::Block | |||
| PARTIAL = "liquids/katex".freeze | |||
| KATEX_EXISTED = "katex_existed".freeze | |||
|
|
|||
| def initialize(tag_name, markup, tokens) | |||
| def initialize(_tag_name, markup, _parse_context) | |||
There was a problem hiding this comment.
I think that markup could benefit from being written as _markup here since it seems unused - thoughts? 😄
There was a problem hiding this comment.
@juliannatetreault Ah but it is being used here; it's just a little obfuscated since it is initialized by the gem itself
There was a problem hiding this comment.
Ohh, I see! Thanks for pointing that out.
juliannatetreault
approved these changes
Jul 2, 2020
pr-triage
bot
added
PR: unreviewed
atsmith813
added
PR: reviewed-approved
atsmith813
force-pushed
the
atsmith813/cleanup-existing-liquid-tags-9024
branch
from
a27f068
to
a8e85b4
Compare
pr-triage
bot
added
PR: unreviewed
atsmith813
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
In #8917 and digging through the
liquidgem source code, we found that the third argument passed toinitializein liquid tags isparse_context, nottokens.While updating these references, I also:
superis called in every liquid tag.I intentionally skipped
PollTag, I need to update more logic on that. That'll be a separate PR.Related Tickets & Documents
Closes #9024
QA Instructions, Screenshots, Recordings
Specs should be appropriate here since I'm not changing any logic or behavior. If you'd like, you can include a bunch of different liquid tags in an article locally to ensure they work 🎉 .
Added tests?
Added to documentation?