Updated Snapper to create snapshot if none exists #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theramis
changed the title
For NUnit tests to be logged in appveyor you need to the use the AppVeyor logger. Unfortunately since we run the same test twice, once for .net core and once for .net framework the AppVeyor logger doesn't detect the difference and only logs the test once, which results in incorrect numbers. Removed AppVeyor logger fully and not going to rely on the number in CI.
theramis
added a commit
that referenced
this pull request
Jan 11, 2021
* Updated Snapper to create snapshot if none exists * Update test projects to .net core 3.1 * Bump appveyor image to VS 2019 * Fix bug with updating snapshots in CI env * Update docs to mention auto creating of initial snapshot * Update test projects to use .net 452 so that the latest xunit works * Remove appveyor logging as its not possible to make it work perfectly For NUnit tests to be logged in appveyor you need to the use the AppVeyor logger. Unfortunately since we run the same test twice, once for .net core and once for .net framework the AppVeyor logger doesn't detect the difference and only logs the test once, which results in incorrect numbers. Removed AppVeyor logger fully and not going to rely on the number in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #69