chore: updated notes on improving typing

therealokoro · Dec 26, 2022 · 5717491 · 5717491
1 parent 2fb3963
commit 5717491
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/packages/anu-vue/src/components/data-table/ADataTable.vue b/packages/anu-vue/src/components/data-table/ADataTable.vue
@@ -26,6 +26,7 @@ defineOptions({
   name: 'ADataTable',
 })
 
+// TODO: https://twitter.com/mattpocockuk/status/1606656367078539264
 const _tableProps = reactivePick(props, Object.keys(tableProps).filter(k => !['rows', 'cols'].includes(k)) as Array<keyof typeof tableProps>)
 
 const _rows = ref<Record<string, unknown>[]>(typeof props.rows !== 'function' ? props.rows : [])

diff --git a/packages/anu-vue/src/components/menu/AMenu.vue b/packages/anu-vue/src/components/menu/AMenu.vue
@@ -167,7 +167,6 @@ if (props.modelValue === undefined) {
     })
   }
   else {
-    console.log('click...')
     useEventListener(refReference, 'click', toggleAlertVisibility)
 
     if (props.persist !== true) {

diff --git a/packages/anu-vue/src/composables/useLayer.ts b/packages/anu-vue/src/composables/useLayer.ts
@@ -12,6 +12,9 @@ export interface LayerProps {
   states: boolean
 }
 
+// Thanks: https://youtu.be/a_m7jxrTlaw
+// type LooseAutocomplete<T extends string> = T | Omit<string, T>
+
 export const useProps = (propOverrides?: Partial<ComponentObjectPropsOptions>) => {
   let props = {
     /**

diff --git a/tsconfig.json b/tsconfig.json
@@ -12,6 +12,7 @@
         "resolveJsonModule": true,
         "skipDefaultLibCheck": true,
         "skipLibCheck": true,
+        "noUncheckedIndexedAccess": true,
         "jsx": "preserve",
         "types": [
             "node"