Line point "Edit line" contextual menu fix. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line point "Edit line" contextual menu wasn't working on Linux as discussed here: https://goo.gl/wHvLta
As per documentation -http://www.tcl.tk/man/tcl8.5/TkCmd/menu.htm#M12 - of Tk menu widget's cascade option:
The associated menu must be a child of the menu containing the cascade entry (this is needed in order for menu traversal to work correctly).
This fix consists of stop reusing the "Edit line" menu from the right panel on the contextual menu and start creating a new one just for the contextual menu.
This probably wasn't an issue on Windows and Mac because, as per above documentation also, only Unix depends on Tk posting and unposting support. Windows and Mac have their own methods.