-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display issues when used within a UITabBarController #39
Comments
This works fine for me:
|
That's very odd. I changed how I add controllers to the UITabBarViewController to match what you showed above and I still have the same results. Here's a screenshot. I have TITokenField in my own project and saw the same thing so it's not something project specific. I tried in the 5.1, 6.0, and 6.0 "tall" simulators and they all behave the same. I'll continue troubleshooting to see what I can find. |
Oh, I think it's a problem in the resizeViews method in the example view controller. It doesn't take into account a UITabBarController when determining its view's new height. |
Excellent.. I'll focus my efforts in there. Thanks! |
That's exactly it. I'll wrap this up in a patch and push it. Thanks for your help! |
Submitted pull request. Sorry, didn't realize it would create a separate issue. This was my first pull request ;) Thanks again for the great component and the help! |
When displayed within a UITabBarController there is about 20 pixels that are blank below the UITableViewController used for the search results.
If you change the didFinishLaunchingWithOptions in the sample project to the code below you reproduce this.
I'm going to continue troubleshooting tonight/tomorrow and will submit a patch if I can find the issue. What I've found so far is the frame passed to initWithFrame is the same size regardless to the tabbar so inside the component there must be some calculation that is getting thrown off. The behavior is the same regardless of the hidesBottomBarWhenPushed BOOL.
Thanks for the awesome component!
The text was updated successfully, but these errors were encountered: