Fixes for JOSS manuscript #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 22, 2022
allanleal
reviewed
Dec 22, 2022
allanleal
reviewed
Dec 22, 2022
Added GEM-Selektor to the list of codes with similar functionalities, fixed style in the paragraph above.
dimitrikulik
approved these changes
Dec 22, 2022
|
Thanks for the comments @allanleal and @dimitrikulik. I will have to convince the editor to allow a normal length manuscript and not a one page "elevator pitch" as it was suggested. |
gdmiron
added a commit
that referenced
this pull request
Mar 2, 2023
* JOSS manuscript * JOSS manuscript * updated paper after comments from co-authors * small paper fixes * small fixes based on JOSS editor comments * Fixes for JOSS manuscript (#57) * fixes to manuscript text, added table with similar codes * text fix * Fixes author name * Add bibentry for `Bell:Deiters:Leal:2022` * Added TEQP as another code with purpose for thermo prop calculation * Fixed alphabetical order (after adding TEQP) * GEM-Selektor to codes with similar functionalities Added GEM-Selektor to the list of codes with similar functionalities, fixed style in the paragraph above. * Added paragraph under Features on automatic differentiation * Added autodiff and Reaktoro bibentries * Replaced Leal2016 by Leal:2015 Co-authored-by: Allan Leal <allanmulin@gmail.com> Co-authored-by: Dimitri Kulik <52164624+dimitrikulik@users.noreply.github.com> * shortened manuscript to aorund 1000 words per request of JOSS editor * fix doi entries * removed duplicate bib entry * clarify application to equilibrium speciation * added badge link to paper --------- Co-authored-by: Allan Leal <allanmulin@gmail.com> Co-authored-by: Dimitri Kulik <52164624+dimitrikulik@users.noreply.github.com> Co-authored-by: Lucy Whalley <l.whalley@northumbria.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.