Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected repr/str in thermopack_state #65

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

morteham
Copy link
Contributor

No description provided.

@vegardjervell
Copy link
Collaborator

is there a reason for accessing the _T and _x attributes directly instead of using the T and molefrac property's? Even though these are "internal" methods, I think consistently using the property's is good practice, in case we ever change them to do some error handling, value validation etc.

@morteham
Copy link
Contributor Author

No - I have changed the code to use temperature and molefrac instead of the internal state variables

Copy link
Collaborator

@vegardjervell vegardjervell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@vegardjervell vegardjervell merged commit b66d7c7 into main Jun 13, 2023
@vegardjervell vegardjervell deleted the state_string_representation branch June 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants