Inital prototype / proof-of-concept for PyBind11/Fortwrap wrapping #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrapping The current `pybind11_bindings.cpp` contains minor manual tweaks that are necessary and have not yet been automated. Specifically: The lambdas exposed to python take `std::vector`s as arguments (such that python can pass a `list`), and forwards `std::vector.data()` to the internal C++ method. This is necessary for non-modifiable, obligatory arguments that are arrays."
…initialization Only implemented the database and handlers, not the actual ctor procedures.
Moved fortran main and cpp main to new directories, and made `rebuild_fortran_prog.sh` up-to-date. Note: `build.sh` is not up to date, and will fail. Also made some code less SHOUTY AND LOUD.
Supports individually building the fortran library, cpp wrapper and cpp wrapper with pybind bindings
… with new build system.
…_test. Messed around and figured out what the problems with the top level CMakeLists.txt were. Modified FortWrapOptions.txt for correct wrapping, and regenerated cpp wrapper. pybind11_bindings still needs some manual editing, specifically adding the .data() part to std::vectors that are passed from a lambda to the internal method, and ensuring that the types in the argument list are correct (optional, modifiable arguments are currently std::vector, but should be p_array_f).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Reopening" PR #61 here so that we can have some nice repo structure :)