[[CHORE]] Test under node 8 #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmendiara
added a commit
that referenced
this pull request
Feb 26, 2018
V8 shipped with node8 break our test and reported a `this.name` inside
a ServerError instantiation, resulting in setting the name for a
NotFoundError to something like `NotFound.Error`
More info
```
1) Therror when using ServerError should have precreated classes for statusCodes:
AssertionError: expected { Object (error, message) } to deeply equal { Object (error, message) }
+ expected - actual
{
- "error": "NotFound.Error"
+ "error": "NotFound"
"message": "The user Sarah does not exists"
}
at Context.<anonymous> (test/therror.spec.js:584:37)
2) Therror when using ServerError should hide information to the client:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:603:30)
3) Therror when using ServerError should set string as message for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:616:30)
4) Therror when using ServerError should set string as cause for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:629:30)
5) Therror when using ServerError should set Number as message for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:643:30)
6) Therror when using ServerError should set Number as cause for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:656:30)
```
Closes #16
jmendiara
added a commit
that referenced
this pull request
Feb 26, 2018
V8 shipped with node8 break our test and reported a `this.name` inside
a ServerError instantiation, resulting in setting the name for a
NotFoundError to something like `NotFound.Error`
More info
```
1) Therror when using ServerError should have precreated classes for statusCodes:
AssertionError: expected { Object (error, message) } to deeply equal { Object (error, message) }
+ expected - actual
{
- "error": "NotFound.Error"
+ "error": "NotFound"
"message": "The user Sarah does not exists"
}
at Context.<anonymous> (test/therror.spec.js:584:37)
2) Therror when using ServerError should hide information to the client:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:603:30)
3) Therror when using ServerError should set string as message for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:616:30)
4) Therror when using ServerError should set string as cause for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:629:30)
5) Therror when using ServerError should set Number as message for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:643:30)
6) Therror when using ServerError should set Number as cause for ServerError:
AssertionError: expected 'ServiceUnavailable.Error' to deeply equal 'ServiceUnavailable'
+ expected - actual
-ServiceUnavailable.Error
+ServiceUnavailable
at Context.<anonymous> (test/therror.spec.js:656:30)
```
Closes #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.