Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land and Tunnel Audit / N-12 #912

Merged
merged 4 commits into from May 31, 2023
Merged

Land and Tunnel Audit / N-12 #912

merged 4 commits into from May 31, 2023

Conversation

mvanmeerbeck
Copy link
Collaborator

Description

https://thesandbox-jira.atlassian.net/browse/LTM-44

Checklist

  • Pull Request references Clickup task
  • Pull Request applies to a single purpose
  • I've added comments to my code where needed
  • I've added / updated natspec
  • I've added / updated tests to show that my changes achieve the desired results
  • I've reviewed my code
  • I've followed established naming conventions and formatting
  • I've generated a coverage report and included a screenshot
  • All tests are passing locally
  • I've added / updated a .md documentation file per smart contract (in the contract directory) based on .docs.example

@mvanmeerbeck mvanmeerbeck requested a review from a team as a code owner April 17, 2023 16:43
@mvanmeerbeck mvanmeerbeck changed the base branch from master to task/land-tunnel-proxy-implementation April 17, 2023 16:43
atkinsonholly
atkinsonholly requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@atkinsonholly atkinsonholly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny typo

@capedcrusader21 capedcrusader21 force-pushed the land-and-tunnel-audit/N-12-typographical-errors branch from e11a210 to 52321e7 Compare May 31, 2023 11:39
@capedcrusader21 capedcrusader21 merged commit 7d7bc08 into task/land-tunnel-proxy-implementation May 31, 2023
5 checks passed
@mvanmeerbeck mvanmeerbeck deleted the land-and-tunnel-audit/N-12-typographical-errors branch December 19, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capedcrusader21 capedcrusader21 capedcrusader21 approved these changes

@atkinsonholly atkinsonholly Awaiting requested review from atkinsonholly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvanmeerbeck @atkinsonholly @capedcrusader21