Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land and tunnel audit / N-16 #918

Merged
merged 2 commits into from May 30, 2023
Merged

Land and tunnel audit / N-16 #918

merged 2 commits into from May 30, 2023

Conversation

mvanmeerbeck
Copy link
Collaborator

Description

https://thesandbox-jira.atlassian.net/browse/LTM-48

Checklist

  • Pull Request references Clickup task
  • Pull Request applies to a single purpose
  • I've added comments to my code where needed
  • I've added / updated natspec
  • I've added / updated tests to show that my changes achieve the desired results
  • I've reviewed my code
  • I've followed established naming conventions and formatting
  • I've generated a coverage report and included a screenshot
  • All tests are passing locally
  • I've added / updated a .md documentation file per smart contract (in the contract directory) based on .docs.example

@mvanmeerbeck mvanmeerbeck requested a review from a team as a code owner April 20, 2023 13:16
@mvanmeerbeck mvanmeerbeck requested review from atkinsonholly and removed request for a team April 20, 2023 13:16
@mvanmeerbeck mvanmeerbeck changed the title Land and tunnel audit/ N-16 Land and tunnel audit / N-16 Apr 20, 2023
@capedcrusader21 capedcrusader21 self-requested a review May 11, 2023 15:02
@capedcrusader21 capedcrusader21 merged commit 22f4bb1 into task/land-tunnel-proxy-implementation May 30, 2023
5 checks passed
@mvanmeerbeck mvanmeerbeck deleted the land-and-tunnel-audit/N-16-inconsistent-use-of-named-return-values branch December 19, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capedcrusader21 capedcrusader21 capedcrusader21 approved these changes

@atkinsonholly atkinsonholly Awaiting requested review from atkinsonholly atkinsonholly was automatically assigned from thesandboxgame/blockchain-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvanmeerbeck @capedcrusader21