-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Custom Types with Repeated Keyword Doesn't Work #24
Comments
I think this is really weird considering, that there is a test exactly for this: https://github.com/thesayyn/protoc-gen-ts/blob/master/test/integration/messagefields.spec.ts Do you have any ideas what might be the problem here? |
Looks like it fails while generating the typescript files. It could be easily traced IMHO. I'll take look at it in a few hours after work. |
I had the same problem. It seems you need to check the build package deploy in npm. When I built and generated locally, I could use it without any problem. |
Could reproduce under same condition. Maybe need to check NPM released package. |
I had no time to work on this. Any help is appreciated. I'll try my best to fix this though. |
Thanks to @dreamershl. A fix (#34) landed for this on master which will be released quickly. |
Building this proto file
throws
I've created a repro here: https://github.com/flolu/protoc-gen-ts-repeated-repro
Basically it seems as if custom Types (in this case
Car
) doesn't work with therepeated
keyword.The text was updated successfully, but these errors were encountered: