Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ts_proto_library: improve rules_js compatibility #181

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

tsawada
Copy link

@tsawada tsawada commented Nov 13, 2022

rules_js's js_binary targets need BAZEL_BINDIR env variable when running as bazel's actions.
With this change, ts_proto_library can be used with rules_js, if users provide rules_js version of protoc-gen-ts under //protoc-gen-ts/bin like this:

load("@npm//:protoc-gen-ts/package_json.bzl", "bin")

bin.protoc_gen_ts_binary(
    name = "protoc-gen-ts",
    visibility = ["//visibility:public"],
)

This PR does not migrate anything to rules_js. However, this small change makes protoc-gen-ts practically usable with rules_js, while being totally harmless to rules_nodejs users.
ref #176

rules_js's js_binary targets need BAZEL_BINDIR env variable when running
as bazel's actions.
With this change, users can use ts_proto_library if they provide rules_js
version of protoc-gen-ts under //protoc-gen-ts/bin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants