feat: ts_proto_library: improve rules_js compatibility #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_js's
js_binary
targets needBAZEL_BINDIR
env variable when running as bazel's actions.With this change,
ts_proto_library
can be used with rules_js, if users provide rules_js version ofprotoc-gen-ts
under//protoc-gen-ts/bin
like this:This PR does not migrate anything to rules_js. However, this small change makes protoc-gen-ts practically usable with rules_js, while being totally harmless to rules_nodejs users.
ref #176