feat: transform tslib __rest helper using goog.reflect.objectProperty #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript when target is less than ES2018 emits `__rest` helper for object spread syntax, which references properties' name via string literal hence breaks Closure Compilation. We transforms such names to appropriate `goog.reflect.objectProperty` calls to make it compatible with Closure Compiler, as described in angular/tsickle#1047.
|
Merged by e4931eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript when target is less than ES2018 emits
__resthelper for object spread syntax,which references properties' name via string literal hence breaks Closure Compilation.
We transforms such names to appropriate
goog.reflect.objectPropertycalls to make it compatible withClosure Compiler, as described in angular/tsickle#1047.