Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore PHP 5.3 compatibility #84

Merged
merged 1 commit into from Feb 11, 2019

Conversation

remicollet
Copy link
Contributor

As, from composer.json, 5.3 is still supported...

@theseer
Copy link
Owner

theseer commented Feb 11, 2019

Duh. Thanks!

Does Fedora actually still need 5.3 compatibility?
Otherwise I'll consider migrating to 7.3...

@theseer theseer merged commit f09ef9d into theseer:master Feb 11, 2019
@remicollet
Copy link
Contributor Author

Fedora only provides PHP 7.2+ ;)

BTW, I still maintain this package in EPEL, which is important for us, as used to build our autoloaders (we don't use composer), and EPEL-6 still have 5.3 by default (EPEL-7 have 5.4...)

EPEL-6 will be EOL in Nov 2020, and EPEL-7 in June 2024 (EPEL-8 should exists in a few weeks / months)

But feel free to raise minimal PHP dependency if it make sense for you
(I a critical issue really hurt us, I will still be able to backport the needed fix)

@remicollet remicollet deleted the issue-1.25.3-php53 branch February 11, 2019 09:34
@remicollet
Copy link
Contributor Author

Perhaps you can keep this commit in master, without releasing a new version, to see if some other users come ti cry. Could give you a good idea of how this package is used.

@theseer
Copy link
Owner

theseer commented Feb 11, 2019

Good idea.

I guess most people these days use composer's autoloader dump or box to generate phars but I somehow like my approach better ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants