Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP7.2 object typehint (#354) #372

Merged
merged 1 commit into from Sep 29, 2019

Conversation

MacFJA
Copy link
Contributor

@MacFJA MacFJA commented Sep 29, 2019

I should have covered all cases.

How I handle it: when the type object is tested, I also check if the type have been resolved (<=> a full class path exist)


But I think the type transformation should be reworked, lots of similar XSL instruction exists. They look alike but are slightly different, which cause the maintainability cost to be quite high.

All those cases should be refactored into one XSLT function (or at least be in the same file, to avoid searching in multiple places).

@theseer theseer merged commit ecf45e6 into theseer:master Sep 29, 2019
@theseer
Copy link
Owner

theseer commented Sep 29, 2019

I agree.

There's quite a few things that need cleaning up I'm afraid. I hope I'll find the time soon to do that.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants