Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have covered all cases.
How I handle it: when the type
object
is tested, I also check if the type have been resolved (<=> a full class path exist)But I think the type transformation should be reworked, lots of similar XSL instruction exists. They look alike but are slightly different, which cause the maintainability cost to be quite high.
All those cases should be refactored into one XSLT function (or at least be in the same file, to avoid searching in multiple places).