CI GUI tests #3
CI GUI tests #3
Conversation
thesiv
force-pushed
the
ci-gui-tests
branch
30 times, most recently
from
ac4ba27
to
179b6a7
Compare
thesiv
force-pushed
the
ci-gui-tests
branch
9 times, most recently
from
b3fb6c3
to
9a39a99
Compare
Remove `apt-get dist-upgrade` command to not get new untested packages which could lead to issues.
The main reason to return EXIT_FAILURE if the test was failed is showing the right status of the test in GitHub CI checks.
If wxUIActionSimulator opens the popup menu using the hot key it will not exit from wxUIActionSimulator::Char() because it calls wxYield() which will not returns until the menu hiding. So allow disabling wxYield() to fix it.
wxTimer uses the application traits when constructing but virtual functions will not work correctly in the constructor (meaning CreateTraits()). So create the timer in the application initialization function. wxConfigBase::Get() also creates the config which also uses the application traits.
The function is required for GTK GUI tests.
Use own UI action simulator in GUI tests which disabling wxYield() to not stuck inside simulated actions.
Add the delay before showing the license dialog. Without the delay the dialog will not be shown under GTK3.
Unfortunately dialogs didn't work as expected under GTK3 and the delay is required inside the modal dialog testing hook invoke handler.
Under GTK up and down arrow keys only change the current radio box item and space key should be pressed to make the selected item current.
There was a problem hiding this comment.
I would love to understand what exactly is the problem with calling wxYield() with GTK 3... It (mostly) works for wx unit tests themselves when executing them in Travis CI environment, so I don't really understand why shouldn't it work in GitHub Actions one. Can you reproduce the problem locally with Xvfb or does it only happen there?
Also, if it affects only wxGTK3, could we enable the tests for wxMSW already? Or are there problems with them too?
| config_ = wxConfigBase::Get(); | ||
| timer_.Start(100); |
There was a problem hiding this comment.
This fix seems to be right, but the comment just before Skeleton ctor must be updated to mention that these files can only be initialized in OnInit().
| @@ -138,7 +141,7 @@ class Skeleton | |||
| wxConfigBase* config_; | |||
| DocManagerEx* doc_manager_; | |||
| wxDocMDIParentFrame* frame_; | |||
| wxTimer timer_; | |||
| wxTimerPtr timer_; | |||
There was a problem hiding this comment.
AFAICS it should be possible to keep using wxTimer object, just call SetOwner() on it later.
Could you please check if this works? If it does, I'd rather revert the changes here and do it like this.
| // Select the last, "Unisex", radio button, by simulating | ||
| // down-arrow twice: female --> male, then male --> unisex. | ||
| ui.Char(WXK_DOWN); | ||
| wxYield(); | ||
| ui.Char(WXK_DOWN); | ||
| wxYield(); | ||
| ui.Char(WXK_SPACE); // And make it current (required under GTK). |
There was a problem hiding this comment.
| ui.Char(WXK_SPACE); // And make it current (required under GTK). | |
| ui.Char(WXK_SPACE); // And make it current (required under GTK and does no harm under MSW). |
Although OTOH it's still a bit wasteful to emulate an unnecessary key press under MSW... maybe we should have some wxUIActionSimulator::SelectRadioButton() helper in the future.
| #include <wx/testing.h> | ||
| #include <wx/filedlg.h> |
There was a problem hiding this comment.
| #include <wx/testing.h> | |
| #include <wx/filedlg.h> | |
| #include <wx/filedlg.h> | |
| #include <wx/testing.h> |
(should be in alphabetic order, strange that this hasn't been picked up by concinnity check)
| @@ -639,6 +671,11 @@ class SkeletonTest final : public Skeleton | |||
| { | |||
| } | |||
|
|
|||
| void EnableYield(bool enabled) | |||
| { | |||
| static_cast<TestEventLoop*>(m_mainLoop)->EnableYield(enabled); | |||
There was a problem hiding this comment.
This is pretty dangerous, it would be better if TestEventLoop registered itself as being active with the application object to avoid the potentially bad cast.
Or at least use dynamic_cast<> here.
|
MSW GUI tests related commits was moved to let-me-illustrate#170. |
Test PR.