Fix variable expansion order with override=False #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now done in two steps: - Parse the value into a sequence of atoms (literal of variable). - Resolve that sequence into a string.
This fixes an issue when a variable is resolved differently in two
bindings.
For instance, take the following env file:
```
PORT=8000
URL=http://localhost:${PORT}
```
With `PORT` set to `1234` in the environment, the environment resulting
from `dotenv_load(override=False)` would be:
```
PORT=1234
URL=http://localhost:8000
```
This was inconsistent and is fixed by this commit. The environment
would now be:
```
PORT=1234
URL=http://localhost:1234
```
with override, and
```
PORT=8000
URL=http://localhost:8000
```
without override.
The behavior of `load_dotenv` is unchanged and always assumes
`override=True`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282