Skip to content

Commit

Permalink
soundwire: bus: add better dev_dbg to track complete() calls
Browse files Browse the repository at this point in the history
Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  • Loading branch information
plbossart committed Dec 15, 2020
1 parent 3ad56db commit e924098
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/soundwire/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,

if (status == SDW_SLAVE_UNATTACHED) {
dev_dbg(&slave->dev,
"%s: initializing completion for Slave %d\n",
"%s: initializing enumeration and init completion for Slave %d\n",
__func__, slave->dev_num);

init_completion(&slave->enumeration_complete);
Expand All @@ -809,7 +809,7 @@ static void sdw_modify_slave_status(struct sdw_slave *slave,
} else if ((status == SDW_SLAVE_ATTACHED) &&
(slave->status == SDW_SLAVE_UNATTACHED)) {
dev_dbg(&slave->dev,
"%s: signaling completion for Slave %d\n",
"%s: signaling enumeration completion for Slave %d\n",
__func__, slave->dev_num);

complete(&slave->enumeration_complete);
Expand Down Expand Up @@ -1784,8 +1784,13 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
if (ret)
dev_err(&slave->dev,
"Update Slave status failed:%d\n", ret);
if (attached_initializing)
if (attached_initializing) {
dev_dbg(&slave->dev,
"%s: signaling initialization completion for Slave %d\n",
__func__, slave->dev_num);

complete(&slave->initialization_complete);
}
}

return ret;
Expand Down

0 comments on commit e924098

Please sign in to comment.