[BUG][CML-H] Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. #1970

sinahuang · 2020-04-01T06:11:41Z

Describe the bug
Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. Function can't be effected when this info displayed.

To Reproduce
1.Boot up system successfully.
2.Check the dmesg.

Reproduce rate
5/5

Expected result
"soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info should not show in dmesg.

Actual result
Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg.

[    4.374101] intel-master sdw-master-1: sdw_deprepare_stream: failed -22
[    4.374103] sdw_deprepare_stream: subdevice #0-Playback: inconsistent state state 1
[    4.374106] intel-master sdw-master-2: sdw_deprepare_stream: failed -22
[    4.374214] sof-audio-pci 0000:00:1f.3: pcm: close stream 2 dir 0
[    4.377065] sof-audio-pci 0000:00:1f.3: ipc tx: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    4.377464] sof-audio-pci 0000:00:1f.3: ipc tx succeeded: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    4.378557]  SDW1-Playback: soc_dpcm_fe_runtime_update doesn't support Multi CPU yet
[    4.382991]  SDW1-Playback: soc_dpcm_fe_runtime_update doesn't support Multi CPU yet
[    4.383024]  SDW1-Playback: soc_dpcm_fe_runtime_update doesn't support Multi CPU yet
[    4.384915] sof-audio-pci 0000:00:1f.3: ipc tx: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    4.385211] sof-audio-pci 0000:00:1f.3: ipc tx succeeded: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    4.385237] sof-audio-pci 0000:00:1f.3: ipc tx: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    4.385526] sof-audio-pci 0000:00:1f.3: ipc tx succeeded: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    4.386336] sof-audio-pci 0000:00:1f.3: pcm: open stream 0 dir 0
[    4.386339] sof-audio-pci 0000:00:1f.3: period min 192 max 16384 bytes
[    4.386341] sof-audio-pci 0000:00:1f.3: period count 2 max 16
[    4.386342] sof-audio-pci 0000:00:1f.3: buffer max 65536 bytes

Test recipe

Kernel:https://github.com/thesofproject/linux/commits/topic/sof-dev commit:3bdd89d
FW: https://github.com/thesofproject/sof/commits/master commit: thesofproject/sof@1e39cee
Tplg: Same with FW branch, sof-cml-rt711-rt1308-rt715.tplg
Platform:CML-H Laptop with codec ALC711, 2 x RT1308, RT715 in SDW mode.

dmesg04.log

The text was updated successfully, but these errors were encountered:

plbossart · 2020-04-01T15:25:16Z

@sinahuang you are looking at the wrong part of the dmesg, there is an earlier issue

[    4.374101] intel-master sdw-master-1: sdw_deprepare_stream: failed -22
[    4.374103] sdw_deprepare_stream: subdevice #0-Playback: inconsistent state state 1
[    4.374106] intel-master sdw-master-2: sdw_deprepare_stream: failed -22

sinahuang · 2020-04-02T01:52:00Z

Yes, tracked another earlier issue by thesofproject/sof#2690

sinahuang · 2020-05-27T08:01:26Z

Issue still can be reproduced on CML-H with latest sof-dev(866e4d5) +master (thesofproject/sof@90ddae9)

plbossart · 2020-05-27T14:37:56Z

Can you try with PR #2070 ?

sinahuang · 2020-05-28T03:24:49Z

Check with PR #2070, aplay -l display "no soundcard", dmesg shows "ASoC: can't create pcm iDisp1 :-22".

[    2.829406] rt715 sdw:3:25d:715:0: sdw_modify_slave_status: signaling completion for Slave 1
[    2.831969] snd_hda_codec_hdmi ehdaudio0D2: hdmi: pcm_num set to 3
[    2.831972] sof-audio-pci 0000:00:1f.3: display power disable
[    2.832024] sof_sdw sof_sdw: rt711-aif1 <-> SDW0 Pin2 mapping ok
[    2.832028] sof_sdw sof_sdw: rt711-aif1 <-> SDW0 Pin3 mapping ok
[    2.832040] sof_sdw sof_sdw: multicodec <-> multicpu mapping ok
[    2.832044] sof_sdw sof_sdw: rt715-aif2 <-> SDW3 Pin2 mapping ok
[    2.832047] sof_sdw sof_sdw: CPU DAI iDisp1 Pin for rtd iDisp1 does not support capture
[    2.832050] sof_sdw sof_sdw: ASoC: can't create pcm iDisp1 :-22
[    2.832155] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x1010f0f successful
[    2.832165] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    2.832178] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    2.832195] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    2.832201] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful

dmesg1.log

plbossart · 2020-06-09T18:44:49Z

@sinahuang can you please re-check, the error with HDMI was fixed, thank you.

sinahuang · 2020-06-10T02:17:09Z

Original issue still can be seen with latest sof-dev(commit:2839e03) +master (commit: b504367) on CML-H.
dmesg.log
sof_trace.log

[    2.138527] sof-audio-pci 0000:00:1f.3: display power disable
[    2.144974] rt711 sdw:0:25d:711:0: Slave impl defined interrupt
[    2.178050]  SDW1-Playback: soc_dpcm_fe_runtime_update doesn't support Multi CPU yet
[    2.178062]  SDW1-Playback: soc_dpcm_fe_runtime_update doesn't support Multi CPU yet
[    2.178077] sof-audio-pci 0000:00:1f.3: ipc tx: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    2.178243] sof-audio-pci 0000:00:1f.3: ipc tx succeeded: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    2.178256] sof-audio-pci 0000:00:1f.3: ipc tx: 0x50010000: GLB_COMP_MSG: SET_VALUE
[    2.178413] sof-audio-pci 0000:00:1f.3: ipc tx succeeded: 0x50010000: GLB_COMP_MSG: SET_VALUE

plbossart · 2020-06-10T02:28:28Z

@bardliao @RanderWang can you please look into this?

bardliao · 2020-06-10T02:41:30Z

@bardliao @RanderWang can you please look into this?

Yes, I will look into this.

bardliao · 2020-06-10T08:54:20Z

@sinahuang Can you try with #2183 ?

bardliao · 2020-06-10T09:08:16Z

@plbossart The fe argument in soc_dpcm_fe_runtime_update() is not only FE, but also BE. See for_each_card_rtds. And it seems that we only need to handle FE in soc_dpcm_fe_runtime_update(). So my idea is to skip BE in soc_dpcm_fe_runtime_update(). What do you think?

sinahuang · 2020-06-10T12:47:50Z

Error can't be reproduced with PR #2183.

plbossart · 2020-06-10T13:22:36Z

No, the fix is simpler:

	if (fe->num_cpus > 1) {
		dev_err(fe->dev,
			"%s doesn't support Multi CPU yet\n", __func__);
		return -EINVAL;
	}

	if (!fe->dai_link->dynamic)
		return 0;

we need to invert the two tests :-)
I'll send a PR later today.

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. BugLink: thesofproject#1970 Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

plbossart · 2020-06-10T14:11:41Z

@sinahuang can you try with PR #2185? Thanks!

sinahuang · 2020-06-11T05:35:57Z

Error not seen on CML-H with PR #2185 +master (commit:700ca2a).

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. BugLink: #1970 Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

sinahuang · 2020-06-12T02:24:58Z

Issue can't be reproduced after PR #2185 merged, so closed it.

plbossart · 2020-06-12T13:54:51Z

Thanks @sinahuang for checking!

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. BugLink: #1970 Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. BugLink: thesofproject#1970 Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> BugLink: thesofproject#1970 Link: https://lore.kernel.org/r/20200612203507.25621-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> BugLink: thesofproject/linux#1970 Link: https://lore.kernel.org/r/20200612203507.25621-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>

[ Upstream commit 96bf62f ] soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> BugLink: thesofproject/linux#1970 Link: https://lore.kernel.org/r/20200612203507.25621-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> BugLink: thesofproject/linux#1970 Link: https://lore.kernel.org/r/20200612203507.25621-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>

[ Upstream commit 96bf62f ] soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> BugLink: thesofproject#1970 Link: https://lore.kernel.org/r/20200612203507.25621-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>

soc_dpcm_fe_runtime_update() is called for all dailinks, and we want to first discard all back-ends, then deal with front-ends. The existing code first reports an error with multi-cpu front-ends, and that check needs to be moved after we know that we are dealing with a front-end. Fixes: 6e1276a ('ASoC: Return error if the function does not support multi-cpu') Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> BugLink: thesofproject#1970 Link: https://lore.kernel.org/r/20200612203507.25621-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>

sinahuang added bug Something isn't working CML Applies to Comet Lake platform labels Apr 1, 2020

mengdonglin added P2 Critical bugs or normal features P3 Low-impact bugs or features and removed P2 Critical bugs or normal features labels Apr 2, 2020

mengdonglin changed the title ~~[BUG][CML-H]"soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg.~~ [BUG][CML-H] Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. Apr 2, 2020

bardliao self-assigned this Jun 10, 2020

plbossart mentioned this issue Jun 10, 2020

ASoC: soc-pcm: fix checks for multi-cpu FE dailinks #2185

Merged

sinahuang closed this as completed Jun 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG][CML-H] Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. #1970

[BUG][CML-H] Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. #1970

sinahuang commented Apr 1, 2020 •

edited by mengdonglin

Loading

plbossart commented Apr 1, 2020

sinahuang commented Apr 2, 2020 •

edited

Loading

sinahuang commented May 27, 2020 •

edited

Loading

plbossart commented May 27, 2020

sinahuang commented May 28, 2020

plbossart commented Jun 9, 2020

sinahuang commented Jun 10, 2020 •

edited

Loading

plbossart commented Jun 10, 2020

bardliao commented Jun 10, 2020

bardliao commented Jun 10, 2020

bardliao commented Jun 10, 2020

sinahuang commented Jun 10, 2020

plbossart commented Jun 10, 2020

plbossart commented Jun 10, 2020

sinahuang commented Jun 11, 2020

sinahuang commented Jun 12, 2020

plbossart commented Jun 12, 2020

[BUG][CML-H] Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. #1970

[BUG][CML-H] Warning "soc_dpcm_fe_runtime_update doesn't support Multi CPU yet" info shows in dmesg. #1970

Comments

sinahuang commented Apr 1, 2020 • edited by mengdonglin Loading

plbossart commented Apr 1, 2020

sinahuang commented Apr 2, 2020 • edited Loading

sinahuang commented May 27, 2020 • edited Loading

plbossart commented May 27, 2020

sinahuang commented May 28, 2020

plbossart commented Jun 9, 2020

sinahuang commented Jun 10, 2020 • edited Loading

plbossart commented Jun 10, 2020

bardliao commented Jun 10, 2020

bardliao commented Jun 10, 2020

bardliao commented Jun 10, 2020

sinahuang commented Jun 10, 2020

plbossart commented Jun 10, 2020

plbossart commented Jun 10, 2020

sinahuang commented Jun 11, 2020

sinahuang commented Jun 12, 2020

plbossart commented Jun 12, 2020

sinahuang commented Apr 1, 2020 •

edited by mengdonglin

Loading

sinahuang commented Apr 2, 2020 •

edited

Loading

sinahuang commented May 27, 2020 •

edited

Loading

sinahuang commented Jun 10, 2020 •

edited

Loading