Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No sound devices detected on Dell XPS 9315 2-in-1 #4399

Closed
bblacher opened this issue May 31, 2023 · 22 comments · Fixed by thesofproject/sof#7727
Closed

[BUG] No sound devices detected on Dell XPS 9315 2-in-1 #4399

bblacher opened this issue May 31, 2023 · 22 comments · Fixed by thesofproject/sof#7727
Labels
bug Something isn't working Community end-user or distro-reported issues Dell SDW SKU SDW Applies to SoundWire bus for codec connection

Comments

@bblacher
Copy link

Describe the bug
I don't get sound from the onboard devices on my Dell XPS 2-in-1 9315. Gnome only shows "Dummy Output".

To Reproduce
Install Arch Linux on a Dell XPS 2-in-1 9315 and install sof-firmware, pipewire, alsa-firmware and experience the lack of sound.

Expected behavior
Have working speakers & microphone.

Output of dmesg | grep sof-audio:

[ 5.264681] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040380
[ 5.264832] sof-audio-pci-intel-tgl 0000:00:1f.3: SoundWire enabled on CannonLake+ platform, using SOF driver
[ 5.264846] sof-audio-pci-intel-tgl 0000:00:1f.3: enabling device (0000 -> 0002)
[ 5.265019] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040380
[ 5.265271] sof-audio-pci-intel-tgl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[ 5.272026] sof-audio-pci-intel-tgl 0000:00:1f.3: use msi interrupt mode
[ 5.288907] sof-audio-pci-intel-tgl 0000:00:1f.3: No SoundWire machine driver found
[ 5.288910] sof-audio-pci-intel-tgl 0000:00:1f.3: hda codecs found, mask 4
[ 5.288911] sof-audio-pci-intel-tgl 0000:00:1f.3: using HDA machine driver skl_hda_dsp_generic now
[ 5.288913] sof-audio-pci-intel-tgl 0000:00:1f.3: DMICs detected in NHLT tables: 0
[ 5.290121] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
[ 5.290124] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
[ 5.290134] sof-audio-pci-intel-tgl 0000:00:1f.3: unknown sof_ext_man header type 3 size 0x30
[ 5.384252] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
[ 5.384257] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
[ 5.499540] sof-audio-pci-intel-tgl 0000:00:1f.3: Topology: ABI 3:22:1 Kernel ABI 3:23:0

@bblacher bblacher added the bug Something isn't working label May 31, 2023
@plbossart plbossart transferred this issue from thesofproject/sof May 31, 2023
@plbossart
Copy link
Member

please attach the result of 'alsa-info', we track Dell devices by 'System SKU' not models.

@plbossart plbossart added the SDW Applies to SoundWire bus for codec connection label May 31, 2023
@bblacher
Copy link
Author

bblacher commented May 31, 2023

I put it in a gist.

The System SKU seems to be 0B34.

@plbossart
Copy link
Member

ok, that's an unknown/unsupported SKU. Gah. I created a new label, maybe that will help at some point.

[8086:51cc] means PCI_DEVICE(0x8086, 0x51cc), /* ADL-M */

Is there a way you can attach the DSDT:

cat /sys/firmware/acpi/tables/DSDT > dsdt.dat
iasl -tc dsdt.dsl
cp dsdt.dsl dsdt.dsl.txt

and attach the last file.

@bblacher
Copy link
Author

bblacher commented Jun 1, 2023

Here you go

@plbossart
Copy link
Member

from the DSDT, I can see this:

Name (_ADR, 0x000030025D071401)  // _ADR: Address <<< RT714 mic codec on link0
Name (_ADR, 0x000130025D131601)  // _ADR: Address <<< RT1316 amplifier on link1

Can you confirm you don't have a 3.5 mm jack on this device? we've seen variants like this before.

@bblacher
Copy link
Author

bblacher commented Jun 1, 2023

I don't have a 3.5 mm jack. The only IO I have are two USB-C ports.

plbossart added a commit to plbossart/sound that referenced this issue Jun 1, 2023
Yet another permutation of devices.

Closes: thesofproject#4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Jun 1, 2023
This device has no 3.5mm jack, only a single amplifier and mic codec.

Closes: thesofproject#4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sof that referenced this issue Jun 1, 2023
Yet another permutation. This needs to be back-ported to 2.2 releases

Closes: thesofproject/linux#4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
Copy link
Member

Can you try the patches in PR #4405 ?

You will also need to unzip and add this file
sof-adl-rt1316-l1-mono-rt714-l0.tplg.gz
in /lib/firmware/intel/sof-tplg

@plbossart plbossart added the Community end-user or distro-reported issues label Jun 1, 2023
@bblacher
Copy link
Author

bblacher commented Jun 1, 2023

@plbossart Do you maybe have some instructions on how to try the patches for me?

The unzip-and-add-file part is clear to me.

@bblacher
Copy link
Author

bblacher commented Jun 1, 2023

Actually, nevermind. I just found this.

I'll try your patches tomorrow.

kv2019i pushed a commit to thesofproject/sof that referenced this issue Jun 2, 2023
Yet another permutation. This needs to be back-ported to 2.2 releases

Closes: thesofproject/linux#4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@bblacher
Copy link
Author

bblacher commented Jun 2, 2023

@plbossart
I installed fedora on a separate partition in order to follow the install instructions more easily, this is why the files attached here show fedora instead of arch.

I just tried your patches and they didn't fix the issue for me. Maybe the topology file is the issue here. On my fedora system all of the topology files in /lib/firmware/intel/sof-tplg are compressed with .xz, I've tried adding your topology file both extracted as you told me as well as compressed with xz default options, neither gets Gnome to pick up my speakers, it still just shows "Dummy Output".

Anyways, here is an updated alsa-info.txt and an updated dsdt.dsl.txt.

@plbossart
Copy link
Member

looks like you are not even loading the SOF driver.

Can you try to add this to /etc/modprobe.d/alsa-base.conf

options snd_intel_dspcfg dsp_driver=3

and add this to file
sof-dyndbg.conf.txt as /etc/modprobe.d/sof-dyndbg.conf

@bblacher
Copy link
Author

bblacher commented Jun 2, 2023

plbossart added a commit that referenced this issue Jun 2, 2023
Yet another permutation of devices.

Closes: #4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit that referenced this issue Jun 2, 2023
This device has no 3.5mm jack, only a single amplifier and mic codec.

Closes: #4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 2, 2023
Yet another permutation of devices.

Closes: thesofproject#4399
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 2, 2023
This device has no 3.5mm jack, only a single amplifier and mic codec.

Closes: thesofproject#4399
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit that referenced this issue Jun 2, 2023
Yet another permutation of devices.

Closes: #4399
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit that referenced this issue Jun 2, 2023
This device has no 3.5mm jack, only a single amplifier and mic codec.

Closes: #4399
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 6, 2023
Yet another permutation of devices.

Closes: thesofproject#4399
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230602202225.249209-18-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Jun 6, 2023
This device has no 3.5mm jack, only a single amplifier and mic codec.

Closes: thesofproject#4399
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230602202225.249209-19-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
@bblacher
Copy link
Author

bblacher commented Jun 7, 2023

@plbossart
Do you have any more instructions for me? I still wasn't able to get the sound working.

@plbossart
Copy link
Member

@bblacher Can you provide the entire dmesg, not filtered? I can't see the SoundWire related stuff with your grep filter.

@bblacher
Copy link
Author

bblacher commented Jun 7, 2023

@plbossart I don't have my device with me right now, I'll get back to you with the logs on Sunday.

@bblacher
Copy link
Author

Here you go

@plbossart
Copy link
Member

Wow, that's wild

[   15.657219] snd_sof_intel_hda_common:hda_init_caps: sof-audio-pci-intel-tgl 0000:00:1f.3: skipping SoundWire, no links enabled

Of course it won't try SoundWire if it's not exposed in ACPI tables...

Can you retry with this "options snd_intel_dspcfg dsp_driver=3" remove and this updated file
sof-dyndbg.conf.txt
as /etc/modprobe.d/sof-dyndbg.conf (the extension matters).

@bblacher
Copy link
Author

Same thing

Btw., could this be the issue here?

"Nothing particularly strange here, most notable is probably just the quick revert of the module loading trial that caused problems for people in rc4 depending on just random timing luck (or rather, lack there-of). So if you tried rc4, and some devices randomly didn't work for you, that was likely the issue." - from the Linux 6.4-rc5 announcement

Anyways, here are my updated files:
dmesg.txt
dsdt.dsl.txt
alsa-info.txt

@plbossart
Copy link
Member

I don't get what happens @bblacher

Can you double-check you have CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE enabled?

The following code should detect SoundWire, but if you didn't compile it in then nothing will happen :-)

#if IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE)
static int snd_intel_dsp_check_soundwire(struct pci_dev *pci)
{
	struct sdw_intel_acpi_info info;
	acpi_handle handle;
	int ret;

	handle = ACPI_HANDLE(&pci->dev);

	ret = sdw_intel_acpi_scan(handle, &info);
	if (ret < 0)
		return ret;

	return info.link_mask;
}
#else
static int snd_intel_dsp_check_soundwire(struct pci_dev *pci)
{
	return 0;
}
#endif

if the code is enabled, you should see this:

	if (!count) {
		dev_warn(&adev->dev, "No SoundWire links detected\n");
		return -EINVAL;
	}

@bblacher
Copy link
Author

I currently don't have the time to dig into this. I'll take a look at this and maybe recompile the kernel with the patches you gave me by the end of next week.

mengdonglin pushed a commit to mengdonglin/sof that referenced this issue Jun 29, 2023
Yet another permutation. This needs to be back-ported to 2.2 releases

Closes: thesofproject/linux#4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
(cherry picked from commit 058e657)
kv2019i pushed a commit to thesofproject/sof that referenced this issue Jun 30, 2023
Yet another permutation. This needs to be back-ported to 2.2 releases

Closes: thesofproject/linux#4399
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
(cherry picked from commit 058e657)
@paulmenzel
Copy link

@plbossart, I think Dell does not officially support GNU/Linux on this device, but can’t you establish an unofficial channel, so users do not have to report this?

@plbossart
Copy link
Member

@plbossart, I think Dell does not officially support GNU/Linux on this device, but can’t you establish an unofficial channel, so users do not have to report this?

I tried since CometLake, it's been 3 generations of devices.
All I can do is tag the bugs as "DELL SDW SKU". Maybe at some point someone will see the light.

heftig added a commit to zen-kernel/zen-kernel that referenced this issue Sep 2, 2023
This reverts commit b62a1a8.

It broke stereo sound on the Dell XPS 13 Plus 9320 (SKU 0AF3),
see thesofproject#4559.

Considering that this apparently wasn't enough to get sound working on
SKU 0B34 (thesofproject#4399) and that
Dell officially supports Linux on 0AF3 but not 0B34, I think this is
safe to revert.

Fixes: thesofproject#4559
Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
sirlucjan pushed a commit to CachyOS/linux that referenced this issue Sep 2, 2023
This reverts commit b62a1a8.

It broke stereo sound on the Dell XPS 13 Plus 9320 (SKU 0AF3),
see thesofproject#4559.

Considering that this apparently wasn't enough to get sound working on
SKU 0B34 (thesofproject#4399) and that
Dell officially supports Linux on 0AF3 but not 0B34, I think this is
safe to revert.

Fixes: thesofproject#4559
Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
jlindgren90 pushed a commit to jlindgren90/linux that referenced this issue Sep 4, 2023
This reverts commit b62a1a8.

It broke stereo sound on the Dell XPS 13 Plus 9320 (SKU 0AF3),
see thesofproject#4559.

Considering that this apparently wasn't enough to get sound working on
SKU 0B34 (thesofproject#4399) and that
Dell officially supports Linux on 0AF3 but not 0B34, I think this is
safe to revert.

Fixes: thesofproject#4559
Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Community end-user or distro-reported issues Dell SDW SKU SDW Applies to SoundWire bus for codec connection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants