ASoC: soc-core: fix kernel oops on dai link remove #1469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soc_dai_link_remove() can be called from topology or on cleanup the card. The kernel oopses if soc_unbind_dai_link() is called in the first case, so add a boolean parameter and conditionally call soc_unbind_dai_link() Fixes: bc7a909 ("ASoC: soc-core: add soc_unbind_dai_link()") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
ranj063
reviewed
Nov 12, 2019
| @@ -1997,7 +2000,7 @@ static void soc_cleanup_card_resources(struct snd_soc_card *card) | |||
| soc_remove_link_dais(card); | |||
|
|
|||
| for_each_card_links_safe(card, link, _link) | |||
| snd_soc_remove_dai_link(card, link); | |||
| snd_soc_remove_dai_link(card, link, true); | |||
There was a problem hiding this comment.
@plbossart isnt the simpler thing to just remove soc_unbind_dai_link() from remove_dai_link() and add it after the call to soc_unbind_dai_link()?
There was a problem hiding this comment.
that's what the code initially did, so that's essentially a revert, yes.
|
I still seeing errors like this either with this commit applied or Morimoto's commit reverted: Can you help me to understand what it do happen and give a clean fix for it? |
|
well, this is on Cyan so not sure if it ever worked. Try bisecting with sof-dev-rebase-2019xxxx tags to see if the recent changes to the core changed stuff. I went as far as 20190821 in some cases... |
plbossart
added a commit
to plbossart/sound
that referenced
this pull request
Nov 15, 2019
The initial change in thesofproject#1469 does not work on Baytrail. This fix suggested on November 13, 2019 by Morimoto-san seems to fix the issues. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
This PR is not good enough on Baytrail/Cherrytrail, let's try PR #1504 |
plbossart
added a commit
that referenced
this pull request
Nov 16, 2019
The initial change in #1469 does not work on Baytrail. This fix suggested on November 13, 2019 by Morimoto-san seems to fix the issues. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
soc_dai_link_remove() can be called from topology or on cleanup the
card. The kernel oopses if soc_unbind_dai_link() is called in the
first case, so add a boolean parameter and conditionally call
soc_unbind_dai_link()
Fixes: bc7a909 ("ASoC: soc-core: add soc_unbind_dai_link()")
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Fixes: #1466