ASoC: SOF: Intel: follow recommended sequences to retrieve DPIB information #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use 'bus->use_posbuf && bus->posbuf.addr' in hda_dsp_ctrl_init_chip(), use the same for hda_dsp_ctrl_stop_chip() Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The existing code is inconsistent, we should only enable DPIB if the 'use_posbuf' field is true. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The code inherited from the Skylake driver does not seem to follow any known hardware recommendations. The only two recommended options are a) use DPIB registers if VC1 traffic is not allowed b) use DPIB DDR update if VC1 traffic is used In all of SOF-based updated, VC1 is not supported so we can 'safely' move to using DPIB registers only. This patch keeps the legacy code, in case there was an undocumented issue lost to history, and adds the DPIB DDR update for additional debug. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
keyonjie,
lgirdwood,
ujfalusi,
lyakh,
kv2019i,
ranj063,
bardliao and
RanderWang
|
@naveen-manohar FYI. possible to test this patch set at some point with dmic and simulation? |
Thanks @juimonen , shall check post I get official Simics Release with fixes for DMIC. Thanks |
RanderWang
reviewed
Sep 8, 2021
|
lyakh
reviewed
Oct 1, 2021
| if (sof_hda_position_quirk == SOF_HDA_POSITION_QUIRK_USE_DPIB_REGISTERS) | ||
| bus->use_posbuf = 0; | ||
| else | ||
| bus->use_posbuf = 1; |
There was a problem hiding this comment.
this is a change in behaviour for the current mode, is this intended?
There was a problem hiding this comment.
the commit message is pretty clear, no?
ranj063
approved these changes
Oct 4, 2021
ujfalusi
reviewed
Oct 5, 2021
ujfalusi
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very intrusive patch coming from an interaction with Intel hardware architects, who mentioned the existing SOF code does not follow recommended sequences. The code in SOF follows the same pattern than the Skylake driver, but the existing work-around does not seem to solve a known problem. Oh well.
This PR adds the recommended sequences, with the selection made by a kernel module parameter to debug any regressions.
Compile-tested only for now, let's see how this works in practice.