Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]Tplg load failed on ADL-P Chrome RVP (ADLP_RVP_SDW) as coreboot doesn't enable all 4 HDMI pipelines #4185

Closed
XiaoyunWu6666 opened this issue May 13, 2021 · 8 comments
Closed

[BUG]Tplg load failed on ADL-P Chrome RVP (ADLP_RVP_SDW) as coreboot doesn't enable all 4 HDMI pipelines #4185

XiaoyunWu6666 opened this issue May 13, 2021 · 8 comments
Assignees
@kv2019i
Labels
ADL Applies to Alder Lake platform bug Something isn't working as expected coreboot Issues caused by coreboot

Comments

@XiaoyunWu6666
Copy link
Contributor

Describe the bug
TPLG load failed on Chrome ADLP_RVP_SDW ,there a mismatch between chrome hardware and TPLG file for ADLP_RVP_SDW [sof-adl-rt711.tplg]

Environment
Kernel Branch: topic/sof-dev
Kernel Commit: 93d91f00
SOF Branch: main
SOF Commit: d337c0a
TPLG= sof-adl-rt711.tplg
Device:ADLP_RVP_SDW

Screenshots or console output
image
@XiaoyunWu6666 XiaoyunWu6666 added bug Something isn't working as expected chrome Chromebooks or ChromeOS ADL Applies to Alder Lake platform labels May 13, 2021
@XiaoyunWu6666
Copy link
Contributor Author

This is a known blocker
#4041 is the related pr

@libinyang
Copy link
Contributor

This is a known issue. We have discussion in #4041 (comment)
We can wait for coreboot to fix it.

@lgirdwood
Copy link
Member

@libinyang @XiaoyunWu6666 if this is duplicate then please mark as duplicate

@libinyang
Copy link
Contributor

@libinyang @XiaoyunWu6666 if this is duplicate then please mark as duplicate

@lgirdwood This is not a duplicated issue, but a known issue.

@mengdonglin mengdonglin added topology Topology issues coreboot Issues caused by coreboot and removed chrome Chromebooks or ChromeOS topology Topology issues labels May 18, 2021
@mengdonglin mengdonglin changed the title [BUG]Tplg load failed on Chrome ADLP_RVP_SDW [BUG]Tplg load failed on ADL-P Chrome RVP (ADLP_RVP_SDW) as coreboot doesn't enable all 4 HDMI pipelines May 18, 2021
@kv2019i
Copy link
Collaborator

kv2019i commented May 18, 2021

Thanks @libinyang ... I also didn't notice this in the tplg review. This is a bit unfortunate -- if we have some coreboot versions that enable it and some that do not (without passing the info in any runtime discoverable interface), that's going to be a mess. So let's try to get the coreboot changed asap.

kv2019i added a commit to kv2019i/linux that referenced this issue May 18, 2021
@kv2019i
ASoC: Intel: boards: sof_sdw: use mach data for ADL RVP DMIC count
41ddbfc 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes: cbbd054 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i mentioned this issue May 18, 2021
Merged
@kv2019i
Copy link
Collaborator

kv2019i commented May 20, 2021

And another PR to address the incorrect DMI info on some of the CI machines: thesofproject/linux#2935

kv2019i added a commit to kv2019i/linux that referenced this issue May 24, 2021
@kv2019i
ASoC: Intel: boards: sof_sdw: use mach data for ADL RVP DMIC count
acfa329 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes: cbbd054 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
plbossart pushed a commit to thesofproject/linux that referenced this issue May 25, 2021
@kv2019i @plbossart
ASoC: Intel: boards: sof_sdw: use mach data for ADL RVP DMIC count
32817e6 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes: cbbd054 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i added a commit to thesofproject/linux that referenced this issue May 28, 2021
@kv2019i
ASoC: Intel: boards: sof_sdw: use mach data for ADL RVP DMIC count
73217ce 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes: cbbd054 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@XiaoyunWu6666
Copy link
Contributor Author

hi @libinyang @kv2019i should this issue be closed?

@kv2019i
Copy link
Collaborator

kv2019i commented Jun 3, 2021

Ack @XiaoyunWu6666 , let's close this.

@kv2019i kv2019i closed this as completed Jun 3, 2021
plbossart pushed a commit to thesofproject/linux that referenced this issue Jun 7, 2021
@kv2019i @plbossart
ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
8b08b6b 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes: cbbd054 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 7, 2021
@kv2019i @intel-lab-lkp
ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
767da75 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes:d25bbe80485f8 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart pushed a commit to thesofproject/linux that referenced this issue Jun 14, 2021
@kv2019i @plbossart
ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
2cefc0c 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes: cbbd054 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 21, 2021
@kv2019i @intel-lab-lkp
ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
71e4340 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes:d25bbe80485f8 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")
BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 23, 2021
@kv2019i @broonie
ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
5053513 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes:d25bbe80485f8 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")

BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210621194057.21711-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sboyanex pushed a commit to aketi-subbu/Backport-series that referenced this issue Sep 12, 2022
@kv2019i @sboyanex
UPSTREAM: ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
a768a9b 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes:d25bbe80485f8 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")

BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210621194057.21711-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 5053513)

BUG=b:238403794
TEST=Test Audio use cases.

Signed-off-by: SHANKAR BOYANE <shankarx.boyane@intel.com>
Change-Id: I3ba0101f43c7d4e6eca25f1b25c6b30dc0ca1ba2
sboyanex pushed a commit to BijinaSafiyaa/Backport-series-jairaj that referenced this issue Sep 13, 2022
@kv2019i @sboyanex
UPSTREAM: ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count
9a9af15 
On the reference boards, number of PCH dmics may vary and the number
should be taken from driver machine data. Remove the SOF_SDW_PCH_DMIC
quirk to make DMIC number configurable.

Fixes:d25bbe80485f8 ("ASoC: Intel: sof_sdw: add quirk for new ADL-P Rvp")

BugLink: thesofproject/sof#4185
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210621194057.21711-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit 5053513)

BUG=b:238403794
TEST=Test Audio use cases.

Signed-off-by: SHANKAR BOYANE <shankarx.boyane@intel.com>
Change-Id: Ib1c549c257b3c80d714dff59cea09e98fbb34788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kv2019i kv2019i

Labels
ADL Applies to Alder Lake platform bug Something isn't working as expected coreboot Issues caused by coreboot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mengdonglin @libinyang @lgirdwood @kv2019i @XiaoyunWu6666