Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DSP crash with HDMI playback on sof-hda-generic tplg #7156

Closed
kv2019i opened this issue Feb 22, 2023 · 2 comments
Closed

[BUG] DSP crash with HDMI playback on sof-hda-generic tplg #7156

kv2019i opened this issue Feb 22, 2023 · 2 comments
Labels
bug Something isn't working as expected MTL Applies to Meteor Lake platform P1 Blocker bugs or important features TGL Applies to Tiger Lake

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Feb 22, 2023

Describe the bug
Hit in CI on 22nd:
https://sof-ci.01.org/sofpr/PR7154/build4093/devicetest/index.html?model=TGLU_UP_HDA_IPC4ZPH&testcase=check-playback-10sec
@kv2019i kv2019i added bug Something isn't working as expected P1 Blocker bugs or important features TGL Applies to Tiger Lake MTL Applies to Meteor Lake platform labels Feb 22, 2023
kv2019i added a commit to kv2019i/sof that referenced this issue Feb 22, 2023
@kv2019i
audio: chain_dma: do not hold spinlock when calling schedule_task_free
c2c8b41 
schedule_task_free() might be a blocking call. E.g. the Zephyr
LL-scheduler implementation can call k_sem_take(). Do not call
this function with a spinlock held.

Link: thesofproject#7156
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i mentioned this issue Feb 22, 2023
Merged
@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 22, 2023

Regression caused by merging of #7073 and #6530 . Both were OK separately, but when both merged, the chain-DMA code systematically hits an assert that is now reported (due to 6530).

@kv2019i kv2019i mentioned this issue Feb 22, 2023
Merged
kv2019i added a commit that referenced this issue Feb 22, 2023
@kv2019i
audio: chain_dma: do not hold spinlock when calling schedule_task_free
a74ad93 
schedule_task_free() might be a blocking call. E.g. the Zephyr
LL-scheduler implementation can call k_sem_take(). Do not call
this function with a spinlock held.

Link: #7156
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Feb 22, 2023

Fix merged to SOF main.

@kv2019i kv2019i closed this as completed Feb 22, 2023
kv2019i added a commit to kv2019i/sof that referenced this issue Feb 24, 2023
@kv2019i
audio: chain_dma: do not hold spinlock when calling schedule_task_free
e346f37 
schedule_task_free() might be a blocking call. E.g. the Zephyr
LL-scheduler implementation can call k_sem_take(). Do not call
this function with a spinlock held.

Link: thesofproject#7156
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected MTL Applies to Meteor Lake platform P1 Blocker bugs or important features TGL Applies to Tiger Lake
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kv2019i