pipeline: allow render pipeline to recover from xrun #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pipeline's ability to recover from xrun for render streams. Normally for render the ppl task is scheduled after trigger start, but in this case trigger start is done on current's task level. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
lgirdwood
approved these changes
Jul 18, 2018
|
I was about to merge when you closed, I guess you have a better fix ? |
|
Probably, just hold on a little bit longer. |
|
You can merge it as it is. |
xiulipan
reviewed
Jul 19, 2018
| @@ -1090,6 +1106,17 @@ static int pipeline_xrun_recover(struct pipeline *p) | |||
| return ret; | |||
| } | |||
|
|
|||
| /* for playback copy it here, because scheduling won't work | |||
| * on this interrupt level | |||
| */ | |||
There was a problem hiding this comment.
So you mean you kept the schedule idle copy in the pipeline trigger start as it will never work there?
Thus this is some workaround for now?
There was a problem hiding this comment.
Exactly. Also my comment is a little bit misleading. To be precised, schedule won't work, because scheduler doesn't allow to add to the list tasks, which are currently running.
keqiaozhang
pushed a commit
to keqiaozhang/sof
that referenced
this pull request
Nov 21, 2018
…flow logger: string overflow warning fix
This was referenced Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pipeline's ability to recover from xrun for render streams.
Normally for render the ppl task is scheduled after trigger start,
but in this case trigger start is done on current's task level.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com