ipc: Refine some IPC data structures to make its size 4bytes aligned #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see comments for the linux parts at thesofproject/linux#48 |
Host communicates with dsp by sending or receiving data in memory windows which are in PCI MMIO space. Some platforms like ICL require the transaction size is 4bytes aligned. So it is better to make the data size 4bytes aligned to make it work on all platforms. Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
|
update my patch, thanks for review |
|
@plbossart merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host communicates with dsp by sending or receiving data in memory
windows which are in PCI MMIO space. Some platforms like ICL require
the transaction size is 4bytes aligned. So it is better to make the
data size 4bytes aligned to make it work on all platforms.
I test on BDW and ICL, pass
Please make sure it is merged with :thesofproject/linux#48,
or you would get kernel panic
Signed-off-by: Rander Wang rander.wang@linux.intel.com