Volume: Mitigate zipper noise by adjusting gain ramp parameters #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: thesofproject#103 "volume: zipper noise with fast changes". The volume ramp length is increased from 64 ms to 250 ms. The vol_work rate to update gain value is increased from every 2 ms to 1 ms. The volume ramp macros are redefined to enter directly the desired ramp length in milliseconds to ease the tuning. Also the volume gain Qxy notation (currently Q2.16) is defined with macros to avoid magic numbers in code in ramp computation. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #103 "volume: zipper noise with fast changes".
The volume ramp length is increased from 64 ms to 250 ms. The vol_work
rate to update gain value is increased from every 2 ms to 1 ms. The
volume ramp macros are redefined to enter directly the desired ramp
length in milliseconds to ease the tuning.
Also the volume gain Qxy notation (currently Q2.16) is defined with macros
to avoid magic numbers in code in ramp computation.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com