[RFT]dai: set config only if the config dai_index matches comp dai_index #158
Conversation
|
@singalsu could you please test this to see if it fixes your issue? |
src/audio/dai.c
Outdated
|
|
||
| /* return if config is not for this comp */ | ||
| if (dai->dai_index != config->dai_index) | ||
| return 0; |
There was a problem hiding this comment.
Add error trace and return -EINVAL?
This looks like something we'd need to do for all DAIs btw.
There was a problem hiding this comment.
@plbossart this is not an error. Basically when the dai_config ipc arrives, the ipc handler calls the dai_config() callback for all comps. So we should just ignore the request if the dai_config is not address for it.
There was a problem hiding this comment.
So either we ignore the request here or maybe fix the ipc handler to send the config only to the relevant comps. I think the latter makes more sense. I will update the PR.
|
@plbossart I have update this pull request to move the dai index check to the ipc handler and tested it on the up squared board. But we should wait until after @singalsu can also confirm. |
|
This patch reduced the number of dai_config() calls for config->type SOF_DAI_INTEL_DMIC from 13 to 3. I use sof-apl-nocodec topology. I wonder why two extra times? It didn't help me to get DMA configured to 32 bits so there must be some other issue in addition. |
Set config only for the comp who's dai_index matches the dai_index in the ipc config. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
|
I tested the updated patch and now there's single dai_config() happening for DMIC. I recommend to merge this patch. Thanks Ranjani! |
Set config only for the comp who's dai_index matches the dai_index
in the ipc config.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com