DMA-Trace: fix dma-trace overflow issue #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
requested changes
Jun 27, 2018
src/lib/dma-trace.c
Outdated
| @@ -391,9 +391,29 @@ void dtrace_event(const char *e, uint32_t length) | |||
|
|
|||
| void dtrace_event_atomic(const char *e, uint32_t length) | |||
| { | |||
| struct dma_trace_buf *buffer = NULL; | |||
There was a problem hiding this comment.
This looks exactly like dtrace_event() now without the locking. The purpose of the atomic call is for low frequency and fast trace messages. If we are overflowing then the atomic user is sending too many trace messages and should be converted to verbose_trace
There was a problem hiding this comment.
yes, it should be convert to verbose_trace.
Refine trace log in pm module. There are too many put|get events, so use verbose trace. And atomic trace is for low frequency and fast trace messages Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
|
This patch look good to me |
lgirdwood
approved these changes
Jul 2, 2018
This was referenced Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine dtrace_event_atomic according to dtrace_event
Signed-off-by: Rander Wang rander.wang@linux.intel.com