platform: imx: Fix PLATFORM_DCACHE_ALIGN #3602
Conversation
At this point PLATFORM_DCACHE_ALIGN is equal with DCACHE_LINE_SIZE which on i.MX boards is 128. Functions like rmalloc and rzalloc are allocating memory aligned at PLATFORM_DCACHE_ALIGN bytes. This means that blocks under 128 bytes are not really used and blocks sized > 128 are preffered for small allocations. This seems to be an unnecessary overhead which results in SOF not being abel to allocate memory for simple pipelines (e.g simple pipeline with a mixer). For this reason, we set PLATFORM_DCACHE_ALIGN to a smaller value (sizeof(void*)) but keep HEAP_BUF_ALIGNMENT unchanged. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
requested review from
jajanusz,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
| @@ -14,7 +14,7 @@ | |||
|
|
|||
|
|
|||
| /* data cache line alignment */ | |||
| #define PLATFORM_DCACHE_ALIGN DCACHE_LINE_SIZE | |||
| #define PLATFORM_DCACHE_ALIGN sizeof(void *) | |||
There was a problem hiding this comment.
Does this build properly? This header might possibly be included by stuff that isn't C code I think...
There was a problem hiding this comment.
@paulstelian97 thanks Paul very good point! This builds properly! You can see that only HEAP_BUF_ALIGNMENT is used from non C code (e.g linker files). This is also the way intel non-cavs platforms are handling the alignment.
|
@lgirdwood if you want you may approve this but please do not merge it. While this fixes our problems on sof-imx-stable-v1.5, i see some errors on master branch. I will merge this PR once I figure out what's happening. |
|
@lgirdwood this is good to merge. the problem was with the topology file and the mixer. It looks like there is something very fishy with the mixer :) |
At this point PLATFORM_DCACHE_ALIGN is equal with DCACHE_LINE_SIZE
which on i.MX boards is 128.
Functions like rmalloc and rzalloc are allocating memory aligned at
PLATFORM_DCACHE_ALIGN bytes. This means that blocks under 128 bytes
are not really used and blocks sized > 128 are preffered for small
allocations.
This seems to be an unnecessary overhead which results in SOF not
being abel to allocate memory for simple pipelines (e.g simple
pipeline with a mixer).
For this reason, we set PLATFORM_DCACHE_ALIGN to a smaller value
(sizeof(void*)) but keep HEAP_BUF_ALIGNMENT unchanged.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com