New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology: tgl-nocodec-ci: add multicore support #4082
Conversation
Generate sof-tgl-nocodec-ci-multicore.tplg for multicore validation coverage. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Hi all, we still want to provide possibility to run CI with multi-core configured, this is aim for that, e.g. run mainline kernel (without dynamic pipeline implementation) with multi-core support. |
@keyonjie thanks got you. |
This solution will force CI to have rules on which files they use for validation, and override the same file for different purposes. |
@plbossart could you please elaborate? AFAICT this PR only adds the generation of a new In an ideal world, where and how would you like multicore to be configured and tested? Should single and multicore tested and presented both in the same test report? |
@marc-hb the kernel only knows about sof-tgl-nocodec.tplg. If you have two or more topology files that need to be expose with the same name, be it through symlinks or file override, then it becomes difficult to know what you are testing. |
I understand confusion will happen but what are the alternatives? Are you suggesting to never validate single and multicore with the same git version, not even for some transition period? Use different git branches? |
@marc-hb I don't see the point of testing single-core configurations indeed. This is a transition period, and it's not clear what's breaking. Once we have the multi-core configuration working for CI purposes, why would we test the single-core version? I think there is really a confusion of what CI is. The purpose is to catch regressions on working configurations. There seems to be a confusion with WIP configurations aiming at fixing bugs. This is not a CI activity but a developer/debug one. Different problems really. |
OK @plbossart @marc-hb @lgirdwood To avoid back and forth, let me close this and roll back to the version of #4028 as the multi-core will be supported soon after the simple fix from thesofproject/linux#2873 get merged. |
Generate sof-tgl-nocodec-ci-multicore.tplg for multicore validation
coverage.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com