platform: disable system agent on Zephyr builds #5557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system agent is not required with SOF Zephyr builds as the Zephyr ll scheduler implementation can track DSP load and print periodic status of the load and any observed overruns in scheduling. Disabling agent is beneficial as agent can create a lot of DMA traffic when DMA trace is enabled. This happens if there is jitter in agent execution, with delta slightly over the warning threshold. This can itself worsen the scheduling variation and lead to actual problems. BugLink: #5556 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
dbaluta
approved these changes
Mar 16, 2022
dbaluta
reviewed
Mar 16, 2022
|
It seems @lyakh sent a similar patch to Zephyr zephyrproject-rtos/zephyr#43410 Thoughts on which is the less confusing option? |
|
zephyrproject-rtos/zephyr#43410 has been merged, so this shouldn't be needed now |
|
Let's disable in the Zephyr and make matching update to the new overlay once it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system agent is not required with SOF Zephyr builds
as the Zephyr ll scheduler implementation can track DSP
load and print periodic status of the load and any observed
overruns in scheduling.
Disabling agent is beneficial as agent can create a lot of DMA traffic
when DMA trace is enabled. This happens if there is jitter in agent
execution, with delta slightly over the warning threshold. This can
itself worsen the scheduling variation and lead to actual problems.
BugLink: #5556
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com