hda-dma: wait for buffer full after starting render #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host DMA should wait for buffer full after starting render to avoid empty samples at the beginning. Temporary solution until DMA unified flow will be implemented. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
keyonjie
reviewed
Jul 9, 2018
| do { | ||
| idelay(PLATFORM_DEFAULT_DELAY); | ||
| dgcs = host_dma_reg_read(dma, channel, DGCS); | ||
| } while (!(dgcs & DGCS_BF)); |
There was a problem hiding this comment.
then how will you handle the pointers alignment with software buffer ones? I think you should do that in one same patch, otherwise, it will introduce noise issue again.
There was a problem hiding this comment.
What pointers alignment do you mean? BDL is much higher, than Host DMA buffer in FW. If there are some issues with Host DMA synchronization, you should consider using SPIB mode.
lgirdwood
approved these changes
Jul 9, 2018
ryans-lee
pushed a commit
to ryans-lee/sof
that referenced
this pull request
Jul 16, 2020
Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host DMA should wait for buffer full after starting render
to avoid empty samples at the beginning. Temporary solution
until DMA unified flow will be implemented.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com