Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKIP CI] .github/zephyr: build with the debug overlay and CONFIG_ASSERT #7508

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 24, 2023

This makes sure Zephyr's -fmacro-prefix-map is working and keeps the
builds reproducible when using a recent enough toolchain.

As found in the CONFIG_ASSERT PR
#6530 (comment)
this is not true for old Xtensa toolchains.

Twice faster than shallow clones without any of the git describe or
other hassle. More info in
zephyrproject-rtos/west#638

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This makes sure Zephyr's -fmacro-prefix-map is working and keeps the
builds reproducible when using a recent enough toolchain.

As found in the CONFIG_ASSERT PR
thesofproject#6530 (comment)
this is not true for old Xtensa toolchains.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 25, 2023

-d builds successfully compared between Windows and Linux in https://github.com/thesofproject/sof/actions/runs/4792504901/jobs/8525051740

Copy link
Collaborator

@paulstelian97 paulstelian97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely interesting, if it also works then way to go!

@kv2019i kv2019i merged commit 6f9f2ee into thesofproject:main Apr 25, 2023
37 checks passed
@marc-hb marc-hb deleted the gha-debug-assert branch April 25, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants