Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove README.rst, it's in sof-docs now #85

Merged
merged 1 commit into from Jul 12, 2018

Conversation

jajanusz
Copy link
Contributor

Remove cmocka ut docs, because they are now in sof-docs repo.

Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add why we remove this in the commit message.

@xiulipan
Copy link
Contributor

@jajanusz
Could we hold this on until the sof-doc is enabled?
We lack docs for newcomers and README maybe still helpful now.

@jajanusz
Copy link
Contributor Author

@xiulipan
Docs are there: https://github.com/thesofproject/sof-docs

Also this file is just doc for cmocka unit tests, you don't need it if you don't run UT.
There are like 3 README's:
/README
/doc/README.host
/doc/README.rst

We need to clean up it by moving what we can to sof-docs and keep only README in root of repo.

Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
@jajanusz jajanusz changed the title doc: remove README.rst doc: remove README.rst, it's in sof-docs now Jul 11, 2018
@mengdonglin
Copy link
Collaborator

CI observed building failure.

Failed Platform: baytrail apollolake cannonlake

configure: error: in `/build/sof/src':
configure: error: C compiler cannot create executables

@lgirdwood lgirdwood merged commit 9051c22 into thesofproject:master Jul 12, 2018
@jajanusz
Copy link
Contributor Author

@mengdonglin
How is it related to rst file?

@lgirdwood
Copy link
Member

@jajanusz no it's related to missing/incorrect CFLAGS (which needs to be fixed ASAP)

@wenqingfu
Copy link

and it's on you :) #78 @jajanusz

@jajanusz jajanusz deleted the remove-cmocka-docs branch July 17, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants